Skip to content

PAYEE-1047: allows users numbers with spaces and 1 or 2 decimals#1177

Open
sergi-hmrc wants to merge 1 commit intomainfrom
PAYEE-1047
Open

PAYEE-1047: allows users numbers with spaces and 1 or 2 decimals#1177
sergi-hmrc wants to merge 1 commit intomainfrom
PAYEE-1047

Conversation

@sergi-hmrc
Copy link
Contributor

  • Unit tests passing
  • Coverage reached
  • Acceptance tests passing
  • Reviewed

masahmad
masahmad previously approved these changes Jan 18, 2023
@platops-pr-bot
Copy link

  • SBT can be updated to 1.7.2 in project/build.properties
  • uk.gov.hmrc.sbt-auto-build can be updated to 3.8.0 in project/plugins.sbt
  • uk.gov.hmrc.play-language in project/AppDependencies.scala can be removed - its already provided by uk.gov.hmrc.play-frontend-hmrc
  • Runtime issues may occur. Change com.typesafe.play.sbt-plugin to 2.8.18 in project/plugins.sbt - to match what uk.gov.hmrc.play-frontend-hmrc uses
  • Deprecated config uk.gov.hmrc.play.bootstrap.AuditModule can be changed to uk.gov.hmrc.play.audit.AuditModule in conf/application.conf
  • There is a bobby warning (builds will be prevented after 31 Mar 2023) - see the pr builder for details
  • org.scalatest.scalatest in project/AppDependencies.scala is not limited to test scope but pulls in test dependencies

Jake-Raffe
Jake-Raffe previously approved these changes Jan 19, 2023

"areEqual" must {
"be the same, ignoring commmas and dots" in {
"be the same, ignoring spaces, commmas and dots" in {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and dots?

PerrettJ4
PerrettJ4 previously approved these changes Jan 19, 2023
@platops-pr-bot
Copy link

  • uk.gov.hmrc.sbt-auto-build can be updated to 3.8.0 in project/plugins.sbt
  • SBT can be updated to 1.7.2 in project/build.properties
  • Scala can be updated from 2.12.13 to 2.13.10 in build.sbt
  • uk.gov.hmrc.sbt-auto-build can be updated to 3.9.0 in project/plugins.sbt
  • uk.gov.hmrc.sbt-distributables can be updated to 2.2.0 in project/plugins.sbt
  • uk.gov.hmrc.play-language in project/AppDependencies.scala can be removed - its already provided by uk.gov.hmrc.play-frontend-hmrc
  • Runtime issues may occur. Change com.typesafe.play.sbt-plugin to 2.8.18 in project/plugins.sbt - to match what uk.gov.hmrc.play-frontend-hmrc uses
  • Deprecated config uk.gov.hmrc.play.bootstrap.AuditModule can be changed to uk.gov.hmrc.play.audit.AuditModule in conf/application.conf
  • There is a bobby warning (builds will be prevented after 31 Mar 2023) - see the pr builder for details
  • org.scalatest.scalatest in project/AppDependencies.scala is not limited to test scope but pulls in test dependencies

@pascal22p pascal22p dismissed stale reviews from PerrettJ4, Jake-Raffe, and masahmad via 21ca1d2 April 20, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants